-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for vertical polygons #6791
Conversation
Thanks for the pull request @hpinkos!
Reviewers, don't forget to make sure that:
I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome. 🌍 🌎 🌏 |
Update CHANGES and specifically mention that this improves KML compatibility. |
@mramato this is ready now |
Apps/Sandcastle/gallery/Polygon.html
Outdated
viewer.zoomTo(viewer.entities); | ||
//Sandcastle_End | ||
var cyanPolygon = viewer.entities.add({ | ||
name : 'Orange polygon with per-position heights and outline', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This name needs to be updated.
Can we add a test for this? The rest of the updater is pretty well covered by tests I believe. |
Looks great @hpinkos, just those couple of comments. |
@mramato ready |
Thanks @hpinkos! |
thanks for adding this @hpinkos ! |
Fixes #3349
We can now render this crazy KML file:
I connected
CoplanarPolygonGeometry
to the Entity API.We use it instead of
PolygonGeometry
whenperPositionHeight: true
andextrudedHeight: undefined
.TODO