Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use polylines on terrain for CZML, KML, and GeoJson #6706

Merged
merged 4 commits into from
Jun 21, 2018

Conversation

likangning93
Copy link
Contributor

Fixes #6700

@cesium-concierge
Copy link

Signed CLA is on file.

@likangning93, thanks for the pull request! Maintainers, we have a signed CLA from @likangning93, so you can review this at any time.

⚠️ I noticed that CHANGES.md has not been updated. If this change updates the public API in any way, fixes a bug, or makes any non-trivial update, please add a bullet point to CHANGES.md and comment on this pull request so we know it was updated. For more info, see the Pull Request Guidelines.


I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome.

🌍 🌎 🌏

@hpinkos
Copy link
Contributor

hpinkos commented Jun 19, 2018

@likangning93 I'm seeing 1 failing test:
DataSources/KmlDataSource when a LineString is clamped to ground and tesselated with z draworder, entity has a polyline geometry and ColorProperty

@likangning93
Copy link
Contributor Author

@hpinkos fixed, missed something while fixing an eslint error... whoops.

@mramato
Copy link
Contributor

mramato commented Jun 20, 2018

  1. This is a breaking change, please add a separate item to CHANGES.md that specifically mentions that KML and GeoJSON now use PolylineGraphics instead of CorridorGraphics when clampToGround is true.

  2. Also add a separate CHANGES item stating the new CZML properties

@likangning93
Copy link
Contributor Author

@mramato @hpinkos updated!

@hpinkos
Copy link
Contributor

hpinkos commented Jun 21, 2018

Looks great @likangning93

@hpinkos hpinkos merged commit 33075c0 into CesiumGS:master Jun 21, 2018
@hpinkos hpinkos deleted the datasourceGroundPolylines branch June 21, 2018 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants