Fix translucent flickering after a pick #5374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
optimization where the OIT buffers weren't cleared when there was no translucent commands being rendered. The issue occurred after rearranging the scene for multiple viewports so the buffers are now only cleared once at the beginning of the frame instead of per viewport.
|
@mramato, can you test if this fixed the issue you were seeing where picking stopped working? |
|
Code LGTM |
Unfortunately the issue is completely random (as far as I can tell anyway), but I'll keep an eye out and let you know if it's still happening after this change. |
|
I can confirm the issue is fixed. Since @pjcozzi already approved the code, I'll merge this as soon as it goes green. |
|
Thanks @bagnell! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix an issue with clearing the OIT buffers after a pick. Removes an
optimization where the OIT buffers weren't cleared when there was no
translucent commands being rendered. The issue occurred after rearranging
the scene for multiple viewports so the buffers are now only cleared once
at the beginning of the frame instead of per viewport.
Fixes #5307.