Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #2823: Allow small extruded rectangles #2905

Merged
merged 4 commits into from
Jul 28, 2015
Merged

Fix #2823: Allow small extruded rectangles #2905

merged 4 commits into from
Jul 28, 2015

Conversation

hpinkos
Copy link
Contributor

@hpinkos hpinkos commented Jul 27, 2015

Fixes #2823: RectangleOutlineGeometry doesn't extrude some heights

@pjcozzi
Copy link
Contributor

pjcozzi commented Jul 27, 2015

@bagnell can you review this?

Merge branch 'master' into issue2823
d82f274 
Conflicts:
	CHANGES.md
@bagnell
Copy link
Contributor

bagnell commented Jul 28, 2015

There are two test failures:
Core/RectangleGeometry computes non-extruded rectangle if height is small
Core/RectangleOutlineGeometry computes non-extruded rectangle if height is small

@hpinkos
Copy link
Contributor Author

hpinkos commented Jul 28, 2015

@bagnell ready

bagnell added a commit that referenced this pull request Jul 28, 2015
@bagnell
Merge pull request #2905 from AnalyticalGraphicsInc/issue2823
b6de984 
Fix #2823: Allow small extruded rectangles
@bagnell bagnell merged commit b6de984 into master Jul 28, 2015
@bagnell bagnell deleted the issue2823 branch July 28, 2015 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hpinkos @pjcozzi @bagnell