fix(BillboardCollection): Fix precision loss in billboard image texcoords #13050
+25
−33
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously a billboard's image offsetX/Y and width/height were encoded as quantized 12-bit floats (0–1) before texture sampling. For texture coordinates "in general" this might be reasonable precision, but knowing offsets into the texture atlas are integers 0–16K in practice, we can skip quantization and losslessly pack the uint16 values into the same space.
Preview:
TODO
Issue number and link
Testing plan
TODO
Author checklist
CONTRIBUTORS.mdCHANGES.mdwith a short summary of my changePR Dependency Tree
This tree was auto-generated by Charcoal