-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Sandcastle using Stratakit #12731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jjspace
wants to merge
16
commits into
sandcastle-v2
Choose a base branch
from
stratakit-ui
base: sandcastle-v2
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Sandcastle using Stratakit #12731
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The purpose of this PR was to do a full facelift to the new version of Sandcastle and embrace the Stratakit UI components. I also focused on solidifying the behavior of the various panels and parts of the app. It should now be very close to how we want it based on our latest designs.
What this PR does
App
component to include a header and application/platform of left navigationlocalStorage
based settings with the theme buttonWhat this PR does NOT do
Issue number and link
Part of #12566
Testing plan
npm run dev
from the Sandcastle package ornpm run build-sandcastle
andnpm start
from the rootconsole.log
,console.warn
andconsole.error
to make sure it displays them all correctlyid
starts on the editorAuthor checklist
CONTRIBUTORS.md
CHANGES.md
with a short summary of my change