Skip to content

Conversation

jjspace
Copy link
Contributor

@jjspace jjspace commented Jun 26, 2025

Description

npm oudated ->

Package           Current  Wanted      Latest  Location                       Depended by
@cesium/engine     18.0.0  18.2.0      18.2.0  node_modules/@cesium/engine    widgets@npm:@cesium/widgets@12.1.0
@spz-loader/core    0.1.0   0.1.0       0.2.0  node_modules/@spz-loader/core  engine@npm:@cesium/engine@18.0.0
cloc               2.11.0  2.11.0  2.6.0-cloc  node_modules/cloc              cesium
jsdoc              3.6.11  3.6.11       4.0.4  node_modules/jsdoc             cesium
lerc                2.0.0   2.0.0       4.0.4  node_modules/lerc              engine@npm:@cesium/engine@18.0.0
meshoptimizer      0.23.0  0.23.0      0.24.0  node_modules/meshoptimizer     engine@npm:@cesium/engine@18.0.0
prettier            3.5.3   3.5.3       3.6.1  node_modules/prettier          cesium

Issue number and link

No issue, prep for release

Testing plan

  • Run rm -rf node_modules and npm install to make sure you have the correct versions
  • Make sure things run as expected
  • Check the docs, prettier changed a statement, seems fine but verify
  • Run npm run cloc and make sure it works

Author checklist

  • I have submitted a Contributor License Agreement
  • I have added my name to CONTRIBUTORS.md
  • I have updated CHANGES.md with a short summary of my change
  • I have added or updated unit tests to ensure consistent code coverage
  • I have updated the inline documentation, and included code examples where relevant
  • I have performed a self-review of my code

@jjspace jjspace requested a review from lukemckinstry June 26, 2025 18:06
Copy link

Thank you for the pull request, @jjspace!

✅ We can confirm we have a CLA on file for you.

Copy link
Contributor

@lukemckinstry lukemckinstry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Good to merge unless you are still waiting on clarification about spz-loader.

@ggetz
Copy link
Contributor

ggetz commented Jun 27, 2025

Let's roll with the pinned version just in case @jjspace. We'll follow up with @weegeekps and @keyboardspecialist on the plan going forward.

@javagl
Copy link
Contributor

javagl commented Jun 27, 2025

Has the splat/SPZ-related functionality already been tested with the new version of the SPZ loader? (I tried this version out a while ago, in a different context, and stumbled over drumath2237/spz-loader#70 , which pretty much boiled down to that it did not work at all - hopefully, this was only one of these CJS/AMD/UMD/ESM...-"glitches" that don't affect CesiumJS 🤞 )

@jjspace
Copy link
Contributor Author

jjspace commented Jun 27, 2025

Let's roll with the pinned version just in case

Fine by me, pinned to the 0.1.0 version that was there before

Has the splat/SPZ-related functionality already been tested with the new version of the SPZ loader?

I did not test it very much since I haven't looked at the splats stuff as much. The changlog didn't seem to indicate anything that should've affected us but that's why I specifically asked.

@lukemckinstry I think this should be good to merge as long as tests pass.

@lukemckinstry lukemckinstry added this pull request to the merge queue Jun 27, 2025
Merged via the queue into main with commit 5435b95 Jun 27, 2025
9 checks passed
@lukemckinstry lukemckinstry deleted the npm-updates branch June 27, 2025 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants