Skip to content

Add resizing panels to Sandcastle #12672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 7, 2025
Merged

Add resizing panels to Sandcastle #12672

merged 2 commits into from
Jul 7, 2025

Conversation

jjspace
Copy link
Contributor

@jjspace jjspace commented Jun 17, 2025

Description

Small and simple change thanks to a really easy-to-use library allotment. I also updated the colors to pull from stratakit to match.

Issue number and link

Part of #12566

Testing plan

  • Run the app however you want
  • Try dragging the center vertical line sideways
    • Make sure the style looks good in light and dark and when hovered
    • Make sure both sides, editor and viewer, resize nicely
    • Make sure changing the size of the window itself still behaves nicely

Author checklist

  • I have submitted a Contributor License Agreement
  • I have added my name to CONTRIBUTORS.md
  • I have updated CHANGES.md with a short summary of my change
  • I have added or updated unit tests to ensure consistent code coverage
  • I have updated the inline documentation, and included code examples where relevant
  • I have performed a self-review of my code

@jjspace jjspace requested a review from ggetz June 17, 2025 18:55
Copy link

Thank you for the pull request, @jjspace!

✅ We can confirm we have a CLA on file for you.

@jjspace jjspace force-pushed the sandcastle-resize branch from 1432969 to 504b5cf Compare June 27, 2025 22:27
Base automatically changed from monaco-prettier to sandcastle-v2 June 30, 2025 15:25
@ggetz
Copy link
Contributor

ggetz commented Jul 7, 2025

The resizing is working great, thanks @jjspace!

@ggetz ggetz merged commit 27075cc into sandcastle-v2 Jul 7, 2025
3 of 5 checks passed
@ggetz ggetz deleted the sandcastle-resize branch July 7, 2025 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants