Skip to content

Fix Sandcastle local build #12603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 8, 2025
Merged

Fix Sandcastle local build #12603

merged 1 commit into from
May 8, 2025

Conversation

jjspace
Copy link
Contributor

@jjspace jjspace commented May 6, 2025

Description

I noticed a small bug that was incorrectly building the Sandcastle standalone.html file into the wrong directory.

Issue number and link

No issue

Testing plan

  • Delete the directories Build/Apps and Build/Sandcastle if they exist
  • run npm run build-apps and check that Build/Apps/Sandcastle has all files including standalone.html
    • Specifically check that Build/Sandcastle does not exist and contain standalone.html (this happens on main)
  • Run PROD=true npm run build-apps and make sure that Build/Sandcastle has all files including standalone.html

Author checklist

  • I have submitted a Contributor License Agreement
  • I have added my name to CONTRIBUTORS.md
  • I have updated CHANGES.md with a short summary of my change
  • I have added or updated unit tests to ensure consistent code coverage
  • I have updated the inline documentation, and included code examples where relevant
  • I have performed a self-review of my code

@jjspace jjspace requested a review from ggetz May 6, 2025 17:46
Copy link

github-actions bot commented May 6, 2025

Thank you for the pull request, @jjspace!

✅ We can confirm we have a CLA on file for you.

@ggetz
Copy link
Contributor

ggetz commented May 8, 2025

Thanks @jjspace! Looks good to me, both locally and in CI.

@ggetz ggetz added this pull request to the merge queue May 8, 2025
Merged via the queue into main with commit f8d7f11 May 8, 2025
10 checks passed
@ggetz ggetz deleted the sandcastle-build-bug branch May 8, 2025 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants