Skip to content

fix QuadtreePrimitive updateHeights callback #12555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

calogeromauceri
Copy link
Contributor

@calogeromauceri calogeromauceri commented Apr 8, 2025

Description

This is a trivial fix for changes introduced by commit 53889cb.

After that commit, the callback defined in Scene.updateHeight expects a cartographic position.
This updates ensures that positions retrieved during QuadtreePrivitive.updateHeights iteration are properly converted to cartographic coordinates before being passed to the callback.
This avoids unneeded computation, which is important because updateHeights is time-constraned. Reducing overhead ensures that entity position updates remain performant and consistent.

Author checklist

  • I have submitted a Contributor License Agreement
  • I have added my name to CONTRIBUTORS.md
  • I have added or updated unit tests to ensure consistent code coverage
  • I have performed a self-review of my code

Copy link

github-actions bot commented Apr 8, 2025

Thank you for the pull request, @calogeromauceri!

✅ We can confirm we have a CLA on file for you.

Copy link
Contributor

@ggetz ggetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @calogeromauceri. The code change here looks good, and thank you for adding additional tests!

I pushed 53889cb as a fix for a broken Sandcastle (that I missed when reviewing the original PR) during the release. I'll verify everything is still working, and if so, this should be good to merge.

@ggetz
Copy link
Contributor

ggetz commented Apr 11, 2025

@calogeromauceri Everything looks great. Since a release went out in the interim, would you mind adding an entry to CHANGES.md with a summary of the fix?

@calogeromauceri
Copy link
Contributor Author

Thanks for reviewing the fix @ggetz. I updated the changes file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants