fix QuadtreePrimitive updateHeights callback #12555
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a trivial fix for changes introduced by commit 53889cb.
After that commit, the callback defined in
Scene.updateHeight
expects a cartographic position.This updates ensures that positions retrieved during
QuadtreePrivitive.updateHeights
iteration are properly converted to cartographic coordinates before being passed to the callback.This avoids unneeded computation, which is important because updateHeights is time-constraned. Reducing overhead ensures that entity position updates remain performant and consistent.
Author checklist
CONTRIBUTORS.md