Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document additional limitations of 3D Tiles classification #11739

Merged
merged 4 commits into from
Jan 4, 2024

Conversation

ptrgags
Copy link
Contributor

@ptrgags ptrgags commented Jan 4, 2024

Description

After investigating #11341 and #11223, the result was that these are limitations of shadow-volume based classification that were not well-documented. The two examples had two different issues:

  1. OSM buildings is not watertight (most buildings do not have a bottom). The stencil test used for shadow volumes assumes that the mesh is closed (so there are the same number of front and back faces to render, so this causes the coloring to be flipped for some fragments:

image

  1. For the other issue, the problem happens because the tileset being classified has translucent primitives. Since translucent primitives do not update the depth buffer, the stencil test will give incorrect results. This leads to artifacts for some camera views:

See This Sandcastle for an example

translucent building (has artifacts) opaque building (no artifacts)
image image

This PR simply documents these additional limitations of 3D Tiles classification.

Issue number and link

Fixes #11341 (by documenting the limitations)

Author checklist

  • I have submitted a Contributor License Agreement
  • I have added my name to CONTRIBUTORS.md
  • I have updated CHANGES.md with a short summary of my change
  • I have added or updated unit tests to ensure consistent code coverage Documentation-only change.
  • I have update the inline documentation, and included code examples where relevant
  • I have performed a self-review of my code

packages/engine/Source/Scene/Cesium3DTileset.js Outdated Show resolved Hide resolved
CHANGES.md Outdated Show resolved Hide resolved
packages/engine/Source/Scene/Model/Model.js Outdated Show resolved Hide resolved
@ptrgags ptrgags requested a review from ggetz January 4, 2024 19:34
@ptrgags
Copy link
Contributor Author

ptrgags commented Jan 4, 2024

@ggetz could you review?

CHANGES.md Outdated Show resolved Hide resolved
@ggetz
Copy link
Contributor

ggetz commented Jan 4, 2024

Thanks @ptrgags!

@ptrgags
Copy link
Contributor Author

ptrgags commented Jan 4, 2024

@ggetz updated!

@ggetz ggetz merged commit 31293c1 into main Jan 4, 2024
9 checks passed
@ggetz ggetz deleted the 11341-document-classification-limitations branch January 4, 2024 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using 3D Tiles for classification doesn't seem to work
2 participants