-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
velocityReference is not supported within an interval. #5738
Comments
shunter
added a commit
that referenced
this issue
Sep 1, 2017
* Improve handling of existing alignedAxis velocity support. We now distinguish properties which must produce a unit cartesian (currently only alignedAxis). For those properties, we always normalize on the client to avoid later errors. * Fix velocityReference use from within an interval. Fixes #5738 * Fix promise handling in CzmlDataSourceSpec. Many tests were calling .load without using the resulting promise. This meant that any exceptions during CZML load would be silently ignored.
shunter
added a commit
that referenced
this issue
Sep 5, 2017
* Improve handling of existing alignedAxis velocity support. We now distinguish properties which must produce a unit cartesian (currently only alignedAxis). For those properties, we always normalize on the client to avoid later errors. * Fix velocityReference use from within an interval. Fixes #5738 * Fix promise handling in CzmlDataSourceSpec. Many tests were calling .load without using the resulting promise. This meant that any exceptions during CZML load would be silently ignored.
shunter
added a commit
that referenced
this issue
Sep 11, 2017
* Improve handling of existing alignedAxis velocity support. We now distinguish properties which must produce a unit cartesian (currently only alignedAxis). For those properties, we always normalize on the client to avoid later errors. * Fix velocityReference use from within an interval. Fixes #5738 * Fix promise handling in CzmlDataSourceSpec. Many tests were calling .load without using the resulting promise. This meant that any exceptions during CZML load would be silently ignored.
shunter
added a commit
that referenced
this issue
Sep 11, 2017
* Improve handling of existing alignedAxis velocity support. We now distinguish properties which must produce a unit cartesian (currently only alignedAxis). For those properties, we always normalize on the client to avoid later errors. * Fix velocityReference use from within an interval. Fixes #5738 * Fix promise handling in CzmlDataSourceSpec. Many tests were calling .load without using the resulting promise. This meant that any exceptions during CZML load would be silently ignored.
shunter
added a commit
that referenced
this issue
Sep 26, 2017
* Improve handling of existing alignedAxis velocity support. We now distinguish properties which must produce a unit cartesian (currently only alignedAxis). For those properties, we always normalize on the client to avoid later errors. * Fix velocityReference use from within an interval. Fixes #5738 * Fix promise handling in CzmlDataSourceSpec. Many tests were calling .load without using the resulting promise. This meant that any exceptions during CZML load would be silently ignored.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Attempting to define an
alignedAxis
as avelocityReference
does not work within an interval, producing the error:RuntimeError: {"interval":"2016-06-17T12:00:30Z/2016-06-17T12:01:00Z","velocityReference":"#position"} is not a valid CZML interval.
In
CzmlDataSource
,velocityReference
is handled directly inprocessAlignedAxis
, which precludes its use anywhere other than as a constantalignedAxis
value.unwrapCartesianInterval
may be a better place to put the handling. This would merit some careful consideration though, as that would allow usingvelocityReference
in any context that needs aCartesian
. For example you could use the velocity direction of an object as another object's position, which would not really make sense. Perhaps we should separate the concepts of a position vector (where magnitude is meaningful) from a direction vector (generally a unit vector). Currently we jumble it all together and assume everything's fine. (which is conventional in Cesium whereCartesian3
represents both kinds of vectors)CZML:
The text was updated successfully, but these errors were encountered: