Replace AutoFill with better property-picking UI
#1762
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Somehow I didn't commit this during the release process.
…taEncodingDetails
3 tasks
j9liu
changed the base branch from
detect-instanced-features
to
ignore-transform-distinction
Contributor
Author
|
Still have to test a few cases, but I'll mark this ready for review anyways just to get the ball rolling. |
j9liu
commented
Nov 19, 2025
| }; | ||
|
|
||
| /** | ||
| * An instance of a CesiumGltf::PropertyTableProperty for a particular glTF in |
Contributor
Author
There was a problem hiding this comment.
Suggested change
| * An instance of a CesiumGltf::PropertyTableProperty for a particular glTF in | |
| * An instance of a CesiumGltf::PropertyTableProperty or CesiumGltf::PropertyTextureProperty for a particular glTF in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Depends on #1757, #1765, so merge those first.
In
UCesiumFeaturesMetadataComponent, the "AutoFill" function is a quick way to grab all of the metadata and feature ID sets on visible tiles, but it does not provide an easy editing experience. The nested storage of properties makes navigating the component's UI very cumbersome, and it gets worse for datasets with huge amounts of varying properties (think Cesium OSM Buildings).This PR replaces "Auto Fill" with a new window that allows for incremental addition of feature ID sets / properties to the tileset.
There is room for UI improvements that probably won't be in scope for this PR:
Issue number or link
No direct issue, but this is to support some of the UI concerns in #1685.
Author checklist
CHANGES.mdwith a short summary of my change (for user-facing changes).[ ] I have added or updated unit tests to ensure consistent code coverage as necessary.Testing plan
TODO
Feature ID texture with KHR_texture_transformProperty texture property with KHR_texture_transform