-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Follow-up for empty MAXAR and VRICON validators #331
Conversation
Register an empty validator for MAXAR_content_3tz. The extension does not have any properties to be validated
Register an empty validator for MAXAR_content_geojson. The extension does not have any properties to be validated
Register empty validators for VRICON_class and VRICON_grid.
I added some fixes for 3TZ validation. This is strictly speaking no longer part of the "follow-up" of the content handling, and could have warranted another PR. But it is related to aspects of the 3TZ validation that I noticed in the context of this PR: When a 3TZ content was referred to with a relative path (i.e. (There are some intricacies for 3TZ: It is tile content, but also an "external tileset", and it always has to be resolved to an absolute path - because it always is a file in the local file system...) Also, there had been no dedicated tests for tilesets with 3TZ content. Now there are three of them:
The last one covers one aspect that was fixed here as well: When the 3TZ was completely invalid, then the validation bailed out with an |
This has now been tested more extensively with real-world data, serves as the base state for #332 , and should therefore be ready for review. |
This builds upon #330 :
It contains a minor generalization that is related to the handling of extensions that allow certain content types: The 3D Tiles Tools already offer a functionality to detect a
ContentDataType
. And this functionality is now used for tracking the extension usage: When the content data type is determined to beCONTENT_TYPE_GLTF
,...GLB
,...3TZ
, or...GEOJSON
, then this is tracked as the3DTILES_content_gltf
,MAXAR_content_3tz
, andMAXAR_content_geojson
being used. (The change starts here). In this context, I also did a minor cleanup of replacing the data type strings with the corresponding constants.It also adds very basic specs for the changes from #330 - right now, these specs are basically only checking that using one of these extensions does not cause the message that said that the extension was not supported. These specs can serve as a "stub"/basis for the case where full validation of these extensions is added later.