Gad/setup #18
Draft
Gad/setup #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Staging 2.5 fork
Staging 2.5 fork
Roy-Certora
commented
Aug 29, 2024
| function _.upgradeToAndCall(address,bytes) external => NONDET; | ||
| } | ||
|
|
||
| /// Is persistent because it mirrors the PoolManager storage. |
There was a problem hiding this comment.
When a copy-paste gives you away :)
Roy-Certora
commented
Aug 29, 2024
|
|
||
| hook Sstore bids[KEY uint256 bid_id].amount uint256 new_amount (uint256 old_amount) { | ||
| bids_amount[bid_id] = new_amount; | ||
| sum_of_bids = sum_of_bids + 1; |
There was a problem hiding this comment.
Is it possible to reset the bid? In that case when new_amount = 0 the sum_of_bids should reduce by 1.
Roy-Certora
commented
Aug 29, 2024
| } | ||
|
|
||
| hook Sstore bids[KEY uint256 bid_id].isActive bool new_acitive (bool old_active) { | ||
| if (new_acitive) { |
There was a problem hiding this comment.
why not new_active && !old_active ?
Roy-Certora
commented
Aug 29, 2024
|
|
||
| function _.upgradeToAndCall(address,bytes) external => NONDET; | ||
|
|
||
| // Node manager summaries: |
There was a problem hiding this comment.
Which rules are violated if you remove summaries for state-changing functions?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.