String Reading and Path Typing #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
H00N24
force-pushed
the
ondrej/string-reading
branch
from
8cb42a7 to
cae9620
Compare
pickx
reviewed
May 9, 2024
src/python_wrapper/src/lib.rs
Outdated
| let elements = Builder::new(&src).build().map_err(|_| { | ||
| let display = path.display(); | ||
| let desc = format!("failed to parse source file: {display}"); | ||
| let desc = String::from("failed to parse source code"); |
There was a problem hiding this comment.
nit, can be reduced to
.map_err(|_| PyRuntimeError::new_err("failed to parse source code"))?;
.envrc
Outdated
Comment on lines
1
to
6
| if command -v nix &>/dev/null; then | ||
| # Load .envrc from certora dir if exists | ||
| [ -f ../.envrc ] && source_env .. | ||
| # Use nix if it's available | ||
| use flake | ||
| fi |
There was a problem hiding this comment.
so to be clear, what's the behavior if nix is unavailable?
There was a problem hiding this comment.
So if the nix is not available direnv will only create a virtual environment using the stdlib venv package and activate the virtual environment.
Comment on lines
+29
to
+32
| p = map(as_list, [p_file, p_file_as_string, p_from_string]) | ||
| assert all( | ||
| x == y for x in p for y in p | ||
| ), "all three parsers should parse the same elements" |
H00N24
force-pushed
the
ondrej/string-reading
branch
from
cae9620 to
dfc7ee3
Compare
pickx
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi in this PR I would like to add some functionality to the Python wrapper:
parse_stringfunction that can parse already loaded string as in the cloud setup we're loading this file from zip in S3 thus we already have it in memoryUnion[str | Pathlike]typing toparseto allow str paths for mypy type-checking + mypy CI checkI've built it on top of the other PR just so I could pass the Rust cargo test exception, we can rebase it on top of the master if we decide to change the previous PR.