Conversation
error: unused imports: `cvl_parser`, `decl_parser`
Error: --> src/parse/tests/cvl2.rs:1:20
|
1 | use crate::parse::{cvl_parser, decl_parser};
| ^^^^^^^^^^ ^^^^^^^^^^^
|
= note: `-D unused-imports` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(unused_imports)]`
error: trait `ToSpan` is never used
Error: --> src/parse/builder.rs:86:7
|
86 | trait ToSpan {
| ^^^^^^
|
= note: `-D dead-code` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(dead_code)]`
error: could not compile `cvldoc_parser_core` (lib) due to 1 previous error
warning: build failed, waiting for other jobs to finish...
error: could not compile `cvldoc_parser_core` (lib test) due to 2 previous errors
ozcodes
reviewed
May 9, 2024
| working-directory: src/python_wrapper | ||
| run: cargo fmt --all --check | ||
| - name: Cargo Tests | ||
| if: success() || failure() |
Contributor
There was a problem hiding this comment.
are there other options besides success and failure ?
Collaborator
There was a problem hiding this comment.
I was also puzzled by this - https://stackoverflow.com/a/58859404 explained it:
If you don't want the function to run when you manually cancel a job [...]
maybe the suggested '!cancelled()' alternative is more readable
Collaborator
Author
There was a problem hiding this comment.
Yes, this is an old trick to do allow_failure: true as in Gitlab CI (run tests even if the syntax check failed). I was not using '!canceled()' as GH VS Code extension will try to reformat to "!canceled()" and then complaints that it should not start with "...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR we're a GitHub actions pipeline that builds the
cvldoc_parserpackage and pushes it into our private CodeArtifacts PyPi.To avoid issues with version rewriting we're using dynamic versioning using git following the PEP440 standard as
{base}(.post{distance}.dev0+{commit})?(currently0.0.0.post208.dev0+ca38360).If we create a new GitHub tag
v2.0.2the release build would be2.0.2and all further commits until the next release would be versioned as2.0.2.post12.dev0+c3an45.Currently, we're supporting all major platforms with basic testing. On push to
masteror GH release we'll build all of them and upload them to both CodeArtifacts PyPi and the GH Release page.@ozcodes do you think we should keep the CircleCI or should we move everything to GitHub Actions?
@pickx I had to remove some Rust code as I was getting errors during the
cargo test, was it expected (57fe133)?Here is an example of a successful run: