Remove static object #508
Remove static object #508
Conversation
| private static final PortfolioVerticle portfolioVerticle = new PortfolioVerticle(); | ||
| private static final BoundingBoxVerticle boundingBoxVerticle = new BoundingBoxVerticle(); | ||
| private static final SegVerticle segVerticle = new SegVerticle(); | ||
| private static final WasabiVerticle wasabiVerticle = new WasabiVerticle(); | ||
| private static final EndpointRouter serverVerticle = new EndpointRouter(); |
There was a problem hiding this comment.
Do these need to be static at all?
| annotationDict.put(versionUuid, DataInfoProperties.builder() | ||
| .annotation(new ArrayList<AnnotationPointProperties>()) | ||
| .imgX(newImagePropValue) | ||
| .imgY(newImagePropValue) | ||
| .imgW(newImagePropValue) | ||
| .imgH(newImagePropValue) | ||
| .build() | ||
| ); |
There was a problem hiding this comment.
I think it makes sense to push the default values into the object definition and use @Builder.Default instead of having this disconnect.
There was a problem hiding this comment.
For the project state transitions.
No. It doesn't. When zipping the image, the current process run in separate thread which is the only way to mark as success.
I also followed the original flow. Found out that I forgot to add the starting process status. Realize when testing this with bigger dataset.
| log.info("DEVEN: " + annotationDict); | ||
|
|
There was a problem hiding this comment.
I guess you forgot to remove this?
There was a problem hiding this comment.
Oh noo. Ok. Thanks
|
Kudos, SonarCloud Quality Gate passed!
|
Description
Remove static object and replace with constructor or getter/setter
Type of change
Please delete options that are not relevant.
Tested on?
Checklist: