Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Remove JsonObject from return value #505

Merged
merged 16 commits into from
Sep 27, 2021

Conversation

devenyantis
Copy link
Contributor

Description

Some return values are changed. Some remain as json object. Also added steps to handle fail cases to map the functionality of frontend.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (Non-breaking change which fixes an issue)
  • New feature (Non-breaking change which adds functionality)
  • Breaking change (Fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update (Example: REST API changes)

Tested on?

  • Windows
  • Linux Ubuntu
  • Centos
  • Mac
  • Others (State here -> xxx )

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged
  • CHANGELOG.md has been updated
  • Update Gitbook REST API Page

@devenyantis devenyantis added the enhancement New feature or request label Sep 15, 2021
@devenyantis devenyantis self-assigned this Sep 15, 2021
Copy link
Collaborator

@treo treo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments here. I've only put them on the first place I noticed something, even when it applies to multiple places.

Copy link
Collaborator

@treo treo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more comments. Again they apply in a few cases, but I didn't put them everywhere, as it is pretty obvious where the same pattern repeats.

Copy link
Collaborator

@treo treo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should be able to use the object mapper in a few more places to deserialize directly, instead of manually pulling data from a JsonObject or JsonArray

@sonarcloud
Copy link

sonarcloud bot commented Sep 27, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@devenyantis devenyantis merged commit a563e60 into v2_alpha_refactor Sep 27, 2021
@devenyantis devenyantis deleted the remove_jsonobject branch September 27, 2021 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants