Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

♻️ Add database facade #502

Merged
merged 13 commits into from
Sep 8, 2021
Merged

♻️ Add database facade #502

merged 13 commits into from
Sep 8, 2021

Conversation

devenyantis
Copy link
Contributor

Description

Adding database facade

Type of change

Please delete options that are not relevant.

  • Bug fix (Non-breaking change which fixes an issue)
  • New feature (Non-breaking change which adds functionality)
  • Breaking change (Fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update (Example: REST API changes)

Tested on?

  • Windows
  • Linux Ubuntu
  • Centos
  • Mac
  • Others (State here -> xxx )

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged
  • CHANGELOG.md has been updated
  • Update Gitbook REST API Page

@devenyantis devenyantis added the enhancement New feature or request label Sep 3, 2021
@devenyantis devenyantis self-assigned this Sep 3, 2021
@codenamewei codenamewei removed their request for review September 4, 2021 00:40
treo
treo requested changes Sep 7, 2021
View reviewed changes
Copy link
Collaborator

@treo treo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly good, just a few more comments.

classifai-core/src/main/java/ai/classifai/database/portfolio/PortfolioDB.java Outdated Show resolved Hide resolved
classifai-core/src/main/java/ai/classifai/router/V1Endpoint.java Outdated Show resolved Hide resolved
classifai-core/src/main/java/ai/classifai/util/message/ReplyHandler.java Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Sep 7, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

treo
treo approved these changes Sep 7, 2021
View reviewed changes
Copy link
Collaborator

@treo treo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@devenyantis devenyantis merged commit 481d3ea into v2_alpha_refactor Sep 8, 2021
@devenyantis devenyantis deleted the deven_add_facade branch September 8, 2021 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@treo treo treo approved these changes

@yipkhenlai yipkhenlai yipkhenlai approved these changes

Assignees

@devenyantis devenyantis

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@devenyantis @treo @yipkhenlai