Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unnecessary collect #1

Merged
merged 3 commits into from
Jun 6, 2023
Merged

remove unnecessary collect #1

merged 3 commits into from
Jun 6, 2023

Conversation

jiacai2050
Copy link
Member

No description provided.

@jiacai2050 jiacai2050 changed the title add iter_generator remove unnecessary Jun 6, 2023
@jiacai2050 jiacai2050 changed the title remove unnecessary remove unnecessary collect Jun 6, 2023
src/xor8/builder.rs Outdated Show resolved Hide resolved
Copy link
Member

@Rachelint Rachelint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Rachelint Rachelint merged commit ac8ef01 into master Jun 6, 2023
@Rachelint Rachelint deleted the remove-collect branch June 6, 2023 09:29
ShiKaiWi pushed a commit to apache/horaedb that referenced this pull request Jun 7, 2023
## Rationale
Related with #967, reduce CPU consumption.

## Detailed Changes
- CeresDB/xorfilter#1
- CeresDB/xorfilter#2

## Test Plan

@zouxiang1993 will benchmark this in his test env.
dust1 pushed a commit to dust1/ceresdb that referenced this pull request Aug 9, 2023
## Rationale
Related with apache#967, reduce CPU consumption.

## Detailed Changes
- CeresDB/xorfilter#1
- CeresDB/xorfilter#2

## Test Plan

@zouxiang1993 will benchmark this in his test env.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants