Skip to content

Commit

Permalink
test: change jenkins reporter
Browse files Browse the repository at this point in the history
PR-URL: nodejs#56808
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
  • Loading branch information
Ceres6 authored Feb 3, 2025
1 parent 793c793 commit 69502d8
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 5 deletions.
3 changes: 1 addition & 2 deletions test/es-module/test-esm-no-addons.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,7 @@ if (isMainThread) {
loadFixture('pkgexports/no-addons').then(
mustCall((module) => {
const message = module.default;

if (process.execArgv.length === 0) {
if (!process.execArgv.includes('--no-addons')) {
assert.strictEqual(message, 'using native addons');
} else {
assert.strictEqual(message, 'not using native addons');
Expand Down
11 changes: 8 additions & 3 deletions tools/test.py
Original file line number Diff line number Diff line change
Expand Up @@ -316,9 +316,7 @@ def HasRun(self, output):

class ActionsAnnotationProgressIndicator(DotsProgressIndicator):
def AboutToRun(self, case):
case.additional_flags = case.additional_flags.copy() if hasattr(case, 'additional_flags') else []
case.additional_flags.append('--test-reporter=./test/common/test-error-reporter.js')
case.additional_flags.append('--test-reporter-destination=stdout')
pass

def GetAnnotationInfo(self, test, output):
traceback = output.stdout + output.stderr
Expand Down Expand Up @@ -1448,6 +1446,9 @@ def BuildOptions():
result.add_option("--type",
help="Type of build (simple, fips, coverage)",
default=None)
result.add_option("--error-reporter",
help="use error reporter",
default=True, action="store_true")
return result


Expand Down Expand Up @@ -1663,6 +1664,10 @@ def Main():
options.node_args.append("--always-turbofan")
options.progress = "deopts"

if options.error_reporter:
options.node_args.append('--test-reporter=./test/common/test-error-reporter.js')
options.node_args.append('--test-reporter-destination=stdout')

if options.worker:
run_worker = join(workspace, "tools", "run-worker.js")
options.node_args.append(run_worker)
Expand Down

0 comments on commit 69502d8

Please sign in to comment.