-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Polkadot v1.4 to v1.5 upgrade #439
base: feat/polkadot-v1.4.0-upgrade
Are you sure you want to change the base?
Feat: Polkadot v1.4 to v1.5 upgrade #439
Conversation
@aie0 @ayushmishra2005 it seems that CI has started to fail from 1.5 polkadot version. could you please take a look?Thanks! |
@Aideepakchaudhary I can see conflicts in this PR. Could you please fix them first and verify whether this branch compiles? |
@Aideepakchaudhary As you mentioned, it has started failing from Polkadot cc @aie0 |
I have fixed the github CI. Please validate once |
runtime/cere/src/lib.rs
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Can you add
derive_impl
to inject default types as mentioned here?
Same for cere_dev?
- Can we use
#[derive_impl(frame_system::config_preludes::TestDefaultConfig as frame_system::DefaultConfig)]
inmock.rs
of pallets? For example: https://github.com/paritytech/polkadot-sdk/blob/a3dc2f15f23b3fd25ada62917bfab169a01f2b0d/substrate/bin/node-template/pallets/template/src/mock.rs#L23
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This feature has already been included as part of the upcoming v1.9.0 upgrade, if it's required for this PR we can included here instead, otherwise it will be added in the upcoming PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@valentinfernandez1 @metricaez @Aideepakchaudhary
When a change is introduced in a specific release, it should be reflected in the corresponding PR for our upgrade. Please ensure that all changes from version 1.5 are incorporated into this PR, and moving forward, all future releases must include their relevant changes as well.
cc @aie0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agree with @ayushmishra2005
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CodeExecutor
was improved by removing NativeElseWasmExecutor
as a part of this
paritytech/polkadot-sdk#2521.
Please incorporate this change.
cc @aie0
Description
This PR is upgrading Runtime's and Node's dependencies from Polkadot-SDK release
v1.4.0
tov1.5.0
Notes
Relevant upgrade's notes and comments.
Process
spec_ver
for bothtestnet
andmainnet
Runtime.TBD
Codebase Upgrade Acceptance Criteria
cargo check
passescargo test
passescargo build
on-- release
profile correctly buildstry-runtime
andruntime-benchmarks
features compileblock-production
config file generates blocks.Runtime & Node Upgrade Acceptance Criteria
Runtime upgrade works on Zombienet
Node upgrade works on Zombienet
Runtime upgrade works on Chopsticks
Try-runtime passes with no pending migrations
<!--- PR TEMPLATE CONTENT STARTS HERE -->
Types of Changes
Please select the branch type you are merging and fill in the relevant template.
<!--- Check the following box with an x if the following applies: -->
Fix or Feature
<!--- Check the following box with an x if the following applies: -->
Types of Changes
<!--- What types of changes does your code introduce? -->
Migrations and Hooks
<!--- Check the following box with an x if the following applies: -->
on_initialize
on_finalize
Checklist for Fix or Feature
<!--- All boxes need to be checked. Follow this checklist before requiring PR review -->
spec_version
has been incremented.network-relayer
's events have been updated according to the blockchain events if applicable.Checklist for Hotfix
<!--- All boxes need to be checked. Follow this checklist before requiring PR review -->
spec_version
has been incremented.dev
has been created.staging
has been created.network-relayer
's events have been updated according to the blockchain events if applicable.Checklist for Release
<!--- All boxes need to be checked. Follow this checklist before requiring PR review -->