Feat: Polkadot v1.2. to v1.4 upgrade #437

Aideepakchaudhary · 2024-10-02T15:55:18Z

Description

This PR is upgrading Runtime's and Node's dependencies from Polkadot-SDK release v1.2.0 to 1.4.0

Notes

Relevant upgrade's notes and comments.

Performed the migration of three FRAME pallets: pallet_nomination_pools, pallet_staking, and pallet_grandpa, and modified the method of passing the wasm_binary parameter in the chain_spec file.
Please validate the following values that we have hardcoded in the code:
- ByteDeposit: In pallet grandpa's config for both the runtimes (cere and cere-dev)
- MaxExposurePageSize: In pallet staking's config for both the runtimes (cere and cere-dev)
- PayoutPeriod: In pallet treasury's config for both the runtimes (cere and cere-dev)
- MaxFreezes: In pallet balance's config for both the runtimes (cere and cere-dev)
Breaking changes:
Kindly refer to the official Polkadot release report for further details: Polkadot v1.4.0
Polkadot release analysis : Polkadot v1.4.0 analysis

Process

Bump workspace dependencies
Fix issues
Bump spec_ver for both testnet and mainnet Runtime.
Bump node version if there were changes in the node. TBD

Codebase Upgrade Acceptance Criteria

cargo check passes
cargo test passes
cargo build on -- release profile correctly builds
try-runtime and runtime-benchmarks features compile
Single node spinned up from binary works and generates blocks
Zombienet network with 2 peers spawned with block-production config file generates blocks.

Runtime & Node Upgrade Acceptance Criteria

Types of Changes

Please select the branch type you are merging and fill in the relevant template.

Hotfix
Release
Fix or Feature

Fix or Feature

Types of Changes

Tech Debt (Code improvements)
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Dependency upgrade (A change in substrate or any 3rd party crate version)

Migrations and Hooks

This change requires a runtime migration.
Modifies on_initialize
Modifies on_finalize

Checklist for Fix or Feature

Change has been tested locally.
Change adds / updates tests if applicable.
Changelog doc updated.
spec_version has been incremented.
network-relayer's events have been updated according to the blockchain events if applicable.
All CI checks have been passed successfully

Checklist for Hotfix

Checklist for Release

runtime/cere/src/lib.rs

metricaez · 2024-10-03T20:15:49Z

runtime/cere/src/lib.rs

@@ -1006,6 +1022,8 @@ impl pallet_grandpa::Config for Runtime {

 parameter_types! {
 	pub const BasicDeposit: Balance = 10 * DOLLARS;       // 258 bytes on-chain
+	//TODO: Validate
+	pub const ByteDeposit: Balance = deposit(0, 1);


Please provide input on which value would you like to use here.

metricaez · 2024-10-03T20:16:30Z

runtime/cere/src/lib.rs

+	type BeneficiaryLookup = IdentityLookup<Self::Beneficiary>;
+	type Paymaster = PayFromAccount<Balances, TreasuryAccount>;
+	type BalanceConverter = UnityAssetBalanceConversion;
+	type PayoutPeriod = ConstU32<10>;


Please review selected value and suggest modification if needed.

metricaez · 2024-10-03T20:16:42Z

runtime/cere/src/lib.rs

@@ -533,6 +538,7 @@ parameter_types! {
 	pub const BondingDuration: sp_staking::EraIndex = 3;
 	pub const SlashDeferDuration: sp_staking::EraIndex = 2;
 	pub const RewardCurve: &'static PiecewiseLinear<'static> = &REWARD_CURVE;
+	pub const MaxExposurePageSize: u32 = 64;


Please review selected value and suggest modification if needed.

runtime/cere-dev/src/lib.rs

metricaez · 2024-10-03T20:17:35Z

runtime/cere-dev/src/lib.rs

@@ -538,6 +543,7 @@ parameter_types! {
 	pub const BondingDuration: sp_staking::EraIndex = 3;
 	pub const SlashDeferDuration: sp_staking::EraIndex = 2;
 	pub const RewardCurve: &'static PiecewiseLinear<'static> = &REWARD_CURVE;
+	pub const MaxExposurePageSize: u32 = 64;


Please review selected value and suggest modification if needed.

metricaez · 2024-10-03T20:19:24Z

runtime/cere-dev/src/lib.rs

@@ -1003,6 +1019,8 @@ impl pallet_grandpa::Config for Runtime {

 parameter_types! {
 	pub const BasicDeposit: Balance = 10 * DOLLARS;       // 258 bytes on-chain
+	//TODO: Validate
+	pub const ByteDeposit: Balance = deposit(0, 1);


Please provide input on which value would you like to use here.

node/service/src/chain_spec.rs

…-upgrade

ayushmishra2005 · 2024-10-15T09:41:08Z

runtime/cere/src/lib.rs

@@ -1015,10 +1033,10 @@ impl pallet_identity::Config for Runtime {
 	type RuntimeEvent = RuntimeEvent;
 	type Currency = Balances;
 	type BasicDeposit = BasicDeposit;
-	type FieldDeposit = FieldDeposit;


@Aideepakchaudhary Please remove unused variableFieldDeposit. Do the same change in cere_dev.

Aideepakchaudhary added 15 commits September 30, 2024 17:07

bump dependnecies and fix implementation

5f95331

fix migration issue

22cc20a

fix tests

e1534a4

bump dependencies and fix runtime impl

b7633f9

fix chain spec

e5e8e1a

fmt

f1d9446

bump spec_version

509154b

fix mock

c64a7d0

fix types for tests

8d24d2f

fmt

164b98c

fix runtime migration

7789626

fix clippy

ab573eb

remove unused types

de1f5f0

fix node version

250b3ba

update changelog file

351fdb7

metricaez reviewed Oct 3, 2024

View reviewed changes

Aideepakchaudhary and others added 6 commits October 4, 2024 13:37

remove TODOs

2a8518a

added some documentation

d846507

choir: spacing

f6c5b15

Merge branch 'feat/polkadot-v1.2.0-upgrade' into feat/polkadot-v1.4.0…

b942a2e

…-upgrade

choir: bump workspace version and update changelog

7656e16

fix CI

ad57dbb

ayushmishra2005 force-pushed the feat/polkadot-v1.2.0-upgrade branch from ff18af0 to 2b82078 Compare October 9, 2024 11:55

Base automatically changed from feat/polkadot-v1.2.0-upgrade to new-staging October 10, 2024 07:25

Aideepakchaudhary and others added 3 commits October 10, 2024 13:50

update mock

90ccc01

Merge branch 'new-staging' into feat/polkadot-v1.4.0-upgrade

85b6e75

resolve lock file confict

cee1d9a

Aideepakchaudhary marked this pull request as ready for review October 10, 2024 12:36

auto-assign bot assigned Aideepakchaudhary Oct 10, 2024

Aideepakchaudhary requested a review from ayushmishra2005 October 10, 2024 16:23

Aideepakchaudhary requested review from yahortsaryk and aie0 October 10, 2024 16:23

Aideepakchaudhary force-pushed the feat/polkadot-v1.4.0-upgrade branch from ff03d9c to cee1d9a Compare October 14, 2024 12:58

ayushmishra2005 requested changes Oct 15, 2024

View reviewed changes

remove unused variables

ce7aa3c

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat: Polkadot v1.2. to v1.4 upgrade #437

Feat: Polkadot v1.2. to v1.4 upgrade #437

Aideepakchaudhary commented Oct 2, 2024 •

edited

Loading

metricaez Oct 3, 2024

metricaez Oct 3, 2024

metricaez Oct 3, 2024

metricaez Oct 3, 2024

metricaez Oct 3, 2024

ayushmishra2005 Oct 15, 2024

Feat: Polkadot v1.2. to v1.4 upgrade #437

Are you sure you want to change the base?

Feat: Polkadot v1.2. to v1.4 upgrade #437

Conversation

Aideepakchaudhary commented Oct 2, 2024 • edited Loading

Description

Notes

Process

Codebase Upgrade Acceptance Criteria

Runtime & Node Upgrade Acceptance Criteria

Types of Changes

Fix or Feature

Types of Changes

Migrations and Hooks

Checklist for Fix or Feature

Checklist for Hotfix

Checklist for Release

metricaez Oct 3, 2024

Choose a reason for hiding this comment

metricaez Oct 3, 2024

Choose a reason for hiding this comment

metricaez Oct 3, 2024

Choose a reason for hiding this comment

metricaez Oct 3, 2024

Choose a reason for hiding this comment

metricaez Oct 3, 2024

Choose a reason for hiding this comment

ayushmishra2005 Oct 15, 2024

Choose a reason for hiding this comment

Aideepakchaudhary commented Oct 2, 2024 •

edited

Loading