Chore: Move constants to runtime-common (#251)

### Description
<!-- Describe what change this PR is implementing -->

1. Constants in both runtimes are identiical. 
2. There is no need for them to have their own separate crates.
3. We introduce `constants.rs` per runtime if some runtime-specific
constants need to be defined.

### Types of Changes
<!--- What types of changes does your code introduce? -->
- [x] Tech Debt (Code improvements)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] Dependency upgrade (A change in substrate or any 3rd party crate
version)

### Migrations and Hooks
<!--- Check the following box with an x if the following applies: -->
- [ ] This change requires a runtime migration.
- [ ] Modifies `on_initialize`
- [ ] Modifies `on_finalize`

### Checklist
<!--- All boxes need to be checked. Follow this checklist before
requiring PR review -->
- [ ] Change has been tested locally.
- [ ] Change adds / updates tests.
- [ ] Changelog doc updated.

node/service/Cargo.toml

@@ -41,16 +41,16 @@ sp-trie = { git = "https://github.com/paritytech/substrate", branch = "polkadot-
 
 # Local
 cere-client = { path = "../client", default-features = false, optional = true }
-cere-dev-runtime-constants = { path = "../../runtime/cere-dev/constants", optional = true }
 cere-rpc = { path = "../../rpc" }
+cere-runtime-common = { path = "../../runtime/common", optional = true }
 
 cere-dev-runtime = { path = "../../runtime/cere-dev", optional = true }
 cere-runtime = { path = "../../runtime/cere", optional = true }
 
 [features]
 default = ["cere-native"]
 cere-native = ["cere-runtime", "cere-client/cere"]
-cere-dev-native = ["cere-dev-runtime", "cere-dev-runtime-constants", "cere-client/cere-dev"]
+cere-dev-native = ["cere-dev-runtime", "cere-runtime-common", "cere-client/cere-dev"]
 
 runtime-benchmarks = [
   "cere-runtime/runtime-benchmarks",

node/service/src/chain_spec.rs

@@ -1,9 +1,9 @@
 #[cfg(feature = "cere-dev-native")]
 use cere_dev_runtime as cere_dev;
-#[cfg(feature = "cere-dev-native")]
-use cere_dev_runtime_constants::currency::DOLLARS as TEST_UNITS;
 #[cfg(feature = "cere-native")]
 use cere_runtime as cere;
+#[cfg(feature = "cere-dev-native")]
+use cere_runtime_common::constants::currency::DOLLARS as TEST_UNITS;
 use jsonrpsee::core::__reexports::serde_json;
 pub use node_primitives::{AccountId, Balance, Block, Signature};
 use pallet_im_online::sr25519::AuthorityId as ImOnlineId;

runtime/cere-dev/Cargo.toml

@@ -92,7 +92,6 @@ pallet-utility = { default-features = false, git = "https://github.com/paritytec
 pallet-vesting = { default-features = false, git = "https://github.com/paritytech/substrate.git", branch = "polkadot-v0.9.40" }
 
 # cere dependencies
-cere-dev-runtime-constants = { path = "./constants", default-features = false }
 cere-runtime-common = { path = "../common", default-features = false }
 ddc-primitives = { path = "../../primitives", default-features = false }
 pallet-ddc-clusters = { version = "4.8.8", default-features = false, path = "../../pallets/ddc-clusters" }
@@ -181,7 +180,6 @@ std = [
   "pallet-ddc-nodes/std",
   "pallet-ddc-staking/std",
   "cere-runtime-common/std",
-  "cere-dev-runtime-constants/std",
   "pallet-ddc-customers/std",
   "pallet-ddc-clusters/std",
   "pallet-ddc-payouts/std",

runtime/cere-dev/src/lib.rs

@@ -99,7 +99,7 @@ use static_assertions::const_assert;
 /// Implementations of some helper traits passed into runtime modules as associated types.
 pub mod impls;
 /// Constant values used within the runtime.
-use cere_dev_runtime_constants::{currency::*, time::*};
+use cere_runtime_common::constants::{currency::*, time::*};
 use impls::Author;
 use sp_runtime::generic::Era;
 

runtime/cere/Cargo.toml

@@ -93,7 +93,6 @@ pallet-vesting = { default-features = false, git = "https://github.com/paritytec
 
 # cere dependencies
 cere-runtime-common = { path = "../common", default-features = false }
-cere-runtime-constants = { path = "./constants", default-features = false }
 ddc-primitives = { path = "../../primitives", default-features = false }
 pallet-ddc-clusters = { version = "4.8.8", default-features = false, path = "../../pallets/ddc-clusters" }
 pallet-ddc-customers = { version = "4.8.8", default-features = false, path = "../../pallets/ddc-customers" }
@@ -182,7 +181,6 @@ std = [
   "pallet-ddc-payouts/std",
   "pallet-ddc-staking/std",
   "cere-runtime-common/std",
-  "cere-runtime-constants/std",
 ]
 runtime-benchmarks = [
   "frame-benchmarking/runtime-benchmarks",

runtime/cere/src/lib.rs

@@ -94,7 +94,7 @@ use static_assertions::const_assert;
 /// Implementations of some helper traits passed into runtime modules as associated types.
 pub mod impls;
 /// Constant values used within the runtime.
-use cere_runtime_constants::{currency::*, time::*};
+use cere_runtime_common::constants::{currency::*, time::*};
 use impls::Author;
 use sp_runtime::generic::Era;
 

runtime/common/src/lib.rs

@@ -1,5 +1,7 @@
 #![cfg_attr(not(feature = "std"), no_std)]
 
+pub mod constants;
+
 use node_primitives::Balance;
 
 /// Convert a balance to an unsigned 256-bit number, use in nomination pools.