Import the image stitching parameters class #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This imports the original parameters file from https://github.com/sohamazing/image-stitcher with some modifications and cleanup. Modifications include: - using pydantic for JSON parsing and validation rather than doing it manually - converting the output format and scan pattern to enums - doing some type annotation syntax updates for the newer syntax - removed the to/from dict methods (I don't think these were used outside of the serialization code that's been replaced with pydantic) I also added a couple very basic tests to ensure we're running the parsing code and the serialization format round-trips. Tested by: - `./dev/autofix_lint.sh` - `./dev/format.sh` - `./dev/type_check.sh` - `uv run python -m image_stitcher.parameters_test`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This imports the original parameters file from https://github.com/sohamazing/image-stitcher with some modifications and cleanup.
Modifications include:
I also added a couple very basic tests to ensure we're running the parsing code and the serialization format round-trips.
Tested by:
./dev/autofix_lint.sh./dev/format.sh./dev/type_check.shuv run python -m image_stitcher.parameters_test