Provide a name when calling da.from_array
#13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the previous commit, I found a small speedup for data that fits in memroy by using numpy arrays in this case rather than dask ones. Interestingly it's faster (TBD under what full range of conditions and why) to then convert this to a dask array before writing out to zarr. It turns out we can speed up this conversion to a dask array by multiple seconds by providing a `name=` parameter to the `from_array` function. If you don't provide a name, it creates one by hashing the data, which for giant stitched images can take several seconds. After this change, the 8x8fov test case I've been using is down to ~12s (from ~16 before this change and the previous one). Tested by: - `./dev/autofix_lint.sh` - `./dev/format.sh` - `./dev/type_check.sh` - `./dev/run_tests.sh`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a previous commit, I found a small speedup for data that fits in memroy by using numpy arrays in this case rather than dask ones. Interestingly it's faster (TBD under what full range of conditions and why) to then convert this to a dask array before writing out to zarr.
It turns out we can speed up this conversion to a dask array by multiple seconds by providing a
name=parameter to thefrom_arrayfunction. If you don't provide a name, it creates one by hashing the data, which for giant stitched images can take several seconds.After this change, the 8x8fov test case I've been using is down to ~12s (from ~16 before this change and the previous one).
Tested by:
./dev/autofix_lint.sh./dev/format.sh./dev/type_check.sh./dev/run_tests.sh