Use skimage for image reading direct to numpy arrays instead of dask #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When reading the raw images from disk, we're reading single fields of view for a single region and timepoint, so we should not have to worry about images not fitting into memory, and we can cut out dask from this step. This both makes profiling easier and also in my testing cuts off about 1s from the 8x8 field of view benchmark I've been using (which is down down in the 10-11s range). Tested by: - `./dev/run_tests.sh`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When reading the raw images from disk, we're reading single fields of view for a single region and timepoint, so we should not have to worry about images not fitting into memory, and we can cut out dask from this step. This both makes profiling easier and also in my testing cuts off about 1s from the 8x8 field of view benchmark I've been using (which is now down in the 10-11s range).
Tested by:
./dev/run_tests.sh