Add some timing utilities and a small speedup #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a couple utilities to make the dev experience for profiling nicer: a context manager that logs the time it takes the context to run, and a context manager that writes stats to disk with cProfile for the contained context. I found a small speedup using these (and a bigger one to come in another commit): use numpy for the stitching itself when the data fits in memory (so far it always seems to be faster to write using dask, even taking into account the time it takes to make a dask array from the numpy one). This shaves off 1-2s from the total run time for the usual 8x8 fov example test case. Tested by: - `./dev/autofix_lint.sh` - `./dev/format.sh` - `./dev/type_check.sh` - `./dev/run_tests.sh`
Collaborator
Author
|
@ianohara adding you as a reviewer mainly as an FYI here, but happy to respond to any feedback you have! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a couple utilities to make the dev experience for profiling nicer: a context manager that logs the time it takes the context to run, and a context manager that writes stats to disk with cProfile for the contained context.
I found a small speedup using these (and a bigger one to come in another commit): use numpy for the stitching itself when the data fits in memory (so far it always seems to be faster to write using dask, even taking into account the time it takes to make a dask array from the numpy one).
This shaves off 1-2s from the total run time for the usual 8x8 fov example test case.
Tested by:
./dev/autofix_lint.sh./dev/format.sh./dev/type_check.sh./dev/run_tests.sh