Choose the chunk size for the output dask array based on available memory #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mory While experimenting with using zarr for arrays instead of dask, I discovered that we could get a modest extra speedup for dask by using even larger chunks. This commit makes us use chunks up to the amount of available memory (up to a maximum of 2**31-1 bytes, which was a hard limit for zarr, and when testing with larger chunks on dask it seemed to hang). Tested by: - `./dev/format.sh` - `./dev/autofix_lint.sh` - `./dev/type_check.sh` - `./dev/run_tests.sh` - run a manual test on an 8x8fov, 3000x3000px, 5-channel image, see it completes faster than before.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While experimenting with using zarr for arrays instead of dask, I discovered that we could get a modest extra speedup for dask by using even larger chunks. This commit makes us use chunks up to the amount of available memory (up to a maximum of 2**31-1 bytes, which was a hard limit for zarr, and when testing with larger chunks on dask it seemed to hang).
Tested by:
./dev/format.sh./dev/autofix_lint.sh./dev/type_check.sh./dev/run_tests.sh