Skip to content

chore: add semver-major ignore for astro in Dependabot config - #190

Merged
JasonCust merged 2 commits into
mainfrom
chore/dependabot-astro-major-ignore-188
Jun 23, 2026
Merged

JasonCust merged 2 commits into
mainfrom
chore/dependabot-astro-major-ignore-188

Conversation

@JasonCust

Copy link
Copy Markdown
Contributor

Summary

  • Adds version-update:semver-major to the Dependabot ignore list for astro in .github/dependabot.yml
  • Prevents premature major version upgrade PRs until the Starlight ecosystem supports the new Astro major version

Context

PR #188 (Dependabot astro 7.0.0 bump) failed CI because @astrojs/starlight@0.40.0 declares peerDependencies: { astro: "^6.4.5" } — no Starlight version supports Astro 7. The existing semver-minor ignore rule prevented minor bumps but allowed the major bump through.

Related

Test plan

@astrojs/starlight@0.40.0 declares peerDependencies: { astro: "^6.4.5" }
and no Starlight version supporting Astro 7 exists. Dependabot PR #188
bumped astro to 7.0.0, causing npm ci to fail with ERESOLVE. Major Astro
upgrades require coordinated ecosystem support and should be manually
initiated after readiness is confirmed.

Closes #188
@coderabbitai

coderabbitai Bot commented Jun 22, 2026 •

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: af6c18de-fa26-45bd-931d-972333bc6cf8

📥 Commits

Reviewing files that changed from the base of the PR and between 96f9350 and 6dcc757.

📒 Files selected for processing (1)
  • .github/dependabot.yml
📜 Recent review details
🔇 Additional comments (1)
.github/dependabot.yml (1)

24-24: LGTM!


Summary by CodeRabbit

  • Chores
    • Updated GitHub Actions dependency update configuration to enable major and minor version updates, expanding the scope of automated dependency management beyond minor updates only.

Walkthrough

This change updates the Dependabot configuration for GitHub Actions so the existing actions-minor-patch group includes both semver minor and semver major version updates.

Changes

Dependabot GitHub Actions configuration

Layer / File(s) Summary
Expand actions update types
.github/dependabot.yml
The actions-minor-patch Dependabot group now includes version-update:semver-major alongside version-update:semver-minor in update-types.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Title check ⚠️ Warning PR title follows conventional commit format with 'chore' type and descriptive lowercase message, but omits required issue number in format (#{issue-number}). Add issue number to title: 'chore: add semver-major ignore for astro in Dependabot config (#188)' to comply with the required format.
Linked Issues check ⚠️ Warning The PR changes ignore rules for Astro major updates, but issue #188 requires verifying Vite v8 compatibility, HTML compression behavior, compiler configuration, and Markdown processor functionality. This PR only prevents the upgrade; address #188 requirements separately by performing compatibility verification, configuration updates, and comprehensive testing before attempting Astro 7 upgrade.
✅ Passed checks (3 passed)
Check name Status Explanation
Out of Scope Changes check ✅ Passed PR modifications are within scope: updating Dependabot configuration to manage Astro major version updates aligns with PR objectives and issue context.
Content Accuracy ✅ Passed Edited docs match current body middleware types and current diagnostic strings; no stale API signatures/imports found.
Zero Tech Debt ✅ Passed The only added line in .github/dependabot.yml is the semver-major ignore entry; no added TODO/FIXME/HACK/XXX comments were found.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Warning

Review ran into problems

🔥 Problems

Linked repositories: Your configuration references 2 linked repositories, but your current plan allows 0. Analyzed ``, skipped CentralPing/ergo, `CentralPing/ergo-router`.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@JasonCust JasonCust self-assigned this Jun 22, 2026
@CentralPing CentralPing deleted a comment from coderabbitai Bot Jun 23, 2026

@JasonCust JasonCust left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lead Architect Review

Verdict: APPROVE (posted as COMMENT — GitHub prevents self-approval)

Surgically correct single-line configuration change that prevents doomed Dependabot PRs for Astro major versions until the Starlight ecosystem supports the target version. Root cause clearly identified (#188 failure mode), DECISIONS.md already documents the decision with removal condition, and tracking issue #189 exists for the deliberate migration.

  • Blocking items: 0
  • Non-blocking items: 0

@JasonCust

Copy link
Copy Markdown
Contributor Author

@coderabbitai full review

@coderabbitai

coderabbitai Bot commented Jun 23, 2026 •

Copy link
Copy Markdown
✅ Action performed

Full review finished.

@JasonCust
JasonCust enabled auto-merge (squash) June 23, 2026 14:39
@JasonCust
JasonCust merged commit a0c0c22 into main Jun 23, 2026
3 checks passed
@JasonCust
JasonCust deleted the chore/dependabot-astro-major-ignore-188 branch June 23, 2026 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant