Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions scripts/disable_removed_beat_tasks.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
from framework.celery_tasks import app as celery_app
from website import settings
from django.db.models import Q
from django_celery_beat.models import PeriodicTask, PeriodicTasks


@celery_app.task(name='scripts.disable_removed_beat_tasks')
def disable_removed_beat_tasks():
"""
Disable django-celery-beat PeriodicTask entries that no longer exist
and re-enable those that do exist, based on the current CeleryConfig.beat_schedule.
"""

beat_schedule_keys = settings.CeleryConfig.beat_schedule.keys() if hasattr(settings.CeleryConfig, 'beat_schedule') else None
if not beat_schedule_keys:
return

desired_task_names = set(beat_schedule_keys) | {'celery.backend_cleanup'} # Built-in backend cleanup task

qs_disable = PeriodicTask.objects.filter(~Q(name__in=desired_task_names))
qs_disable.update(enabled=False)
qs_enable = PeriodicTask.objects.filter(name__in=desired_task_names)
qs_enable.update(enabled=True)
PeriodicTasks.update_changed() # Notify django-celery-beat of the changes
5 changes: 5 additions & 0 deletions website/settings/defaults.py
Original file line number Diff line number Diff line change
Expand Up @@ -587,6 +587,7 @@ class CeleryConfig:
'osf.external.spam.tasks',
'api.share.utils',
'scripts.remove_after_use.merge_notification_subscription_provider_ct',
'scripts.disable_removed_beat_tasks',
)

# Modules that need metrics and release requirements
Expand All @@ -600,6 +601,10 @@ class CeleryConfig:
# Setting up a scheduler, essentially replaces an independent cron job
# Note: these times must be in UTC
beat_schedule = {
'disable_removed_beat_tasks': {
'task': 'scripts.disable_removed_beat_tasks',
'schedule': crontab(minute=0, hour=0),
},
'retract_registrations': {
'task': 'scripts.retract_registrations',
'schedule': crontab(minute=0, hour=5), # Daily 12 a.m
Expand Down
Loading