Skip to content

[ENG-7387] remove sharev2 push#11012

Merged
aaxelb merged 1 commit intoCenterForOpenScience:feature/share-cleanupgrade-2025from
aaxelb:mob/2025-03-05
Mar 13, 2025
Merged

[ENG-7387] remove sharev2 push#11012
aaxelb merged 1 commit intoCenterForOpenScience:feature/share-cleanupgrade-2025from
aaxelb:mob/2025-03-05

Conversation

@aaxelb
Copy link
Contributor

@aaxelb aaxelb commented Mar 5, 2025

Purpose

let us finally delete old code from SHARE

Changes

stop sending metadata updates to the old "sharev2 push" (but don't worry, they're still sent via /trove/ingest)

QA Notes

Please make verification statements inspired by your code and what your code touches.

  • Verify updates to public items (including creation/deletion) are correctly reflected:
    • on the osf search page
    • in sharev2 search api at /api/v2/search/creativeworks/_search?q=...

What are the areas of risk?

Any concerns/considerations/questions that development raised?

Documentation

Side Effects

Ticket

ENG-7387

@aaxelb aaxelb changed the title delete sharev2 push [ENG-7387] [wip][mob] gizmob 2025-03-05 Mar 5, 2025
@aaxelb aaxelb changed the base branch from develop to feature/share-cleanupgrade-2025 March 5, 2025 20:05
@aaxelb aaxelb marked this pull request as ready for review March 5, 2025 20:05
@aaxelb aaxelb changed the title [wip][mob] gizmob 2025-03-05 [ENG-7387] remove sharev2 push Mar 5, 2025
@aaxelb aaxelb requested a review from felliott March 5, 2025 20:25
Copy link
Member

@felliott felliott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aaxelb aaxelb merged commit 32938eb into CenterForOpenScience:feature/share-cleanupgrade-2025 Mar 13, 2025
6 checks passed
@aaxelb aaxelb deleted the mob/2025-03-05 branch April 23, 2025 18:20
brianjgeiger pushed a commit that referenced this pull request Apr 24, 2025
## Purpose
clean up code we don't need anymore (and avoid error messages when CenterForOpenScience/SHARE#859 )

## Changes
contains #11012
Vlad0n20 pushed a commit to Vlad0n20/osf.io that referenced this pull request May 5, 2025
clean up code we don't need anymore (and avoid error messages when CenterForOpenScience/SHARE#859 )

contains CenterForOpenScience#11012
ihorsokhanexoft pushed a commit to ihorsokhanexoft/osf.io that referenced this pull request Jun 4, 2025
## Purpose
clean up code we don't need anymore (and avoid error messages when CenterForOpenScience/SHARE#859 )

## Changes
contains CenterForOpenScience#11012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants