[ENG-8975] Feature/redirect service support

[futa-ikeda]

Ticket

Purpose

Changes

Side Effects

API Documentation

QE Notes

CE Notes

[sh-andriy]

Looks good overall, this follows the existing patterns well and the implementation is clean.

One small cleanup needed in addon_service/admin/__init__.py:110-112:

enum_multiple_choice_fields = {
      "int_supported_features": StorageSupportedFeatures,
  }

ExternalRedirectService doesn't have an int_supported_features field, so this config does nothing. Should just remove these lines.

Optionally, for consistency with other service types, you could add a validate_redirect_imp_number validator in validators.py and call it in a clean() method on the model - but not blocking since the current setup still works fine.

Otherwise LGTM

[futa-ikeda]

ExternalRedirectService doesn't have an int_supported_features field, so this config does nothing. Should just remove these lines.

Optionally, for consistency with other service types, you could add a validate_redirect_imp_number validator in validators.py and call it in a clean() method on the model - but not blocking since the current setup still works fine.

I've opted for just removing those lines. My thinking is, it may be best to keep it as lightweight as possible, and if the need arises, we can add the validator later?