Skip to content

Conversation

@nsemets
Copy link
Collaborator

@nsemets nsemets commented Feb 2, 2026

  • Ticket: []
  • Feature flag: n/a

Summary of Changes

  1. Added translations stream for nav menu items computed.

Screenshot(s)

Before the fix
image

After the fix:
image

@nsemets nsemets requested a review from brianjgeiger February 2, 2026 14:20
brianjgeiger
brianjgeiger previously approved these changes Feb 2, 2026
Copy link
Contributor

@brianjgeiger brianjgeiger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! @adlius will merge this using the normal procedure for a hotfix.

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 60.439% (+0.003%) from 60.436%
when pulling 614bf23 on nsemets:hotfix/nav-menu-translations
into 065fb94 on CenterForOpenScience:main.

@adlius
Copy link
Contributor

adlius commented Feb 2, 2026

@nsemets Just curious: I checked both test and prod and don't see this issue, so I guess it doesn't always happen? Why would it happen and how does this fix it?

@brianjgeiger
Copy link
Contributor

@adlius It happens when you reload the page. Try reloading a few times, it should show pretty quickly on test and staging3.

@adlius adlius changed the base branch from main to hotfix/26.2.1 February 3, 2026 15:30
@adlius adlius dismissed brianjgeiger’s stale review February 3, 2026 15:30

The base branch was changed.

@adlius adlius merged commit 95f82db into CenterForOpenScience:hotfix/26.2.1 Feb 3, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants