Skip to content

Comments

[ENG-9758] Follow-up fix: reverts #761#780

Merged
brianjgeiger merged 1 commit intofeature/notifications-refactorfrom
revert-761-fix/notification-prefs
Nov 20, 2025
Merged

[ENG-9758] Follow-up fix: reverts #761#780
brianjgeiger merged 1 commit intofeature/notifications-refactorfrom
revert-761-fix/notification-prefs

Conversation

@cslzchen
Copy link
Contributor

Reverts #761

Reason: this breaks notification settings for Preprint submissions updated

@cslzchen cslzchen changed the title Revert "[ENG-9758] Change settings page to default to correct notifications" [ENG-9758] Follow-up fix: reverts #761 Nov 19, 2025
Copy link
Contributor

@Ostap-Zherebetskyi Ostap-Zherebetskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cslzchen
Copy link
Contributor Author

@brianjgeiger the actual fix happens in the BE (CenterForOpenScience/osf.io#11454). We also have to revert the FE fix (#761) for things to work properly.

@brianjgeiger brianjgeiger merged commit c57489f into feature/notifications-refactor Nov 20, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants