[ENG-9618] avoid creator.affiliationsAbsoluteUrl.includes(currentInstitutionId) checking to allow project contributor rendering for institutions #777
Closed
mkovalua wants to merge 1 commit intoCenterForOpenScience:feature/pbs-25.04from
Conversation
…checking to allow project contributor rendering for institutions
Contributor
Author
|
closed because another PR is merged for the ticket #801 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… checking to allow project contributor rendering for institutions
Purpose
Contributors column showing blank for some projects
Summary of Changes
avoid creator.affiliationsAbsoluteUrl.includes(currentInstitutionId) checking to allow project contributor rendering for institutions
Screenshot(s)
Side Effects
I decided to keep the PR in draft for now because of possible stuff :
if we avoid the condition should we add additional logic (for example mark somehow contributors on rendering that does not match the condition)
QA Notes