[ENG-9753] Show addon icon in User Connected Addons page#770
Merged
nsemets merged 1 commit intoCenterForOpenScience:feature/pbs-25-24from Nov 26, 2025
Merged
Conversation
futa-ikeda
commented
Nov 14, 2025
| getAuthorizedAddons(addonType: string, referenceId: string): Observable<AuthorizedAccountModel[]> { | ||
| const params = { | ||
| [`fields[external-${addonType}-services]`]: 'external_service_name,credentials_format', | ||
| [`fields[external-${addonType}-services]`]: 'external_service_name,credentials_format,icon_url', |
Contributor
Author
There was a problem hiding this comment.
Could also be convinced to remove this fields param entirely. Will result in us overfetching stuff from the API, but it may prevent future issues on this page
futa-ikeda
force-pushed
the
fix/addon-icon
branch
from
061f804 to
6f9f9d8
Compare
futa-ikeda
force-pushed
the
fix/addon-icon
branch
from
6f9f9d8 to
d1070ff
Compare
nsemets
previously approved these changes
Nov 18, 2025
nsemets
approved these changes
Nov 26, 2025
nsemets
merged commit 8dadfe6
into
CenterForOpenScience:feature/pbs-25-24
3 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Summary of Changes
icon_urlas requested field in includedexternal-storage-servicesin request to fetch user's authorized accountsScreenshot(s)
icon_urlattr in the network requestSide Effects
QA Notes