Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sam/cram input support #75

Merged
merged 4 commits into from
Mar 24, 2021
Merged

sam/cram input support #75

merged 4 commits into from
Mar 24, 2021

Conversation

matthdsm
Copy link

No description provided.

@matthdsm
Copy link
Author

fixes #51

tomiles
tomiles requested changes Mar 24, 2021
View reviewed changes
Copy link

@tomiles tomiles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides some comment/doc changes to clearly indicate 'aligned reads' explicitly everywhere, this looks good!

README.md Outdated Show resolved Hide resolved
wisecondorX/convert_tools.py Outdated Show resolved Hide resolved
wisecondorX/convert_tools.py Outdated Show resolved Hide resolved
@matthdsm
Copy link
Author

Comments fixed!

tomiles
tomiles approved these changes Mar 24, 2021
View reviewed changes
Copy link

@tomiles tomiles left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go

@matthdsm matthdsm merged commit b2d38a8 into master Mar 24, 2021
@matthdsm matthdsm deleted the feature/cram_support branch March 24, 2021 11:46
@matthdsm matthdsm mentioned this pull request Mar 24, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomiles tomiles tomiles approved these changes

@leraman leraman Awaiting requested review from leraman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matthdsm @tomiles