Skip to content

Replace Python C extension with wildcard #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 2, 2022
Merged

Replace Python C extension with wildcard #4

merged 2 commits into from
Sep 2, 2022

Conversation

anurlybayev
Copy link
Contributor

Wouldn't this be a better approach instead of adding modifying the setup.py for every build?

@anurlybayev anurlybayev requested a review from jimgao1 August 27, 2022 02:58
@anurlybayev
Copy link
Contributor Author

@jimgao1 thoughts on this change?

@jimgao1
Copy link
Contributor

jimgao1 commented Aug 27, 2022

I think we should make the wildcard a bit more specific. Something like "habitat_cuda.cpython*.so".

@anurlybayev anurlybayev merged commit bb124e4 into main Sep 2, 2022
@anurlybayev anurlybayev deleted the add-wildcards branch September 2, 2022 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimgao1 jimgao1 Awaiting requested review from jimgao1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anurlybayev @jimgao1