Skip to content

Updated setup.py to add and link cuda libraries #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Apr 19, 2023

Conversation

michaelshin
Copy link
Contributor

Changes made:

  • Added a custom step when building the wheel for DeepView.Predict
    • This step ensures that the habitat_cuda library's rpath looks for the CUDA related libraries in the Python package directory directories and not the local directories. See screenshot below for the output of ldd
      updated_libraries
    • Also reverted the rpath to original path after the wheel is built in case a user is doing an editable install/development
  • Added extras_requires that include the necessary CUDA libraries for each respective version of CUDA.

@michaelshin
Copy link
Contributor Author

To install this on your machine, go to the analyzer directory and run pip install ".[cuda117]" . This will install DeepView.Predict in your Python environment.

Go to the site-packages of your python environment and go to habitat. Run ldd on the habitat_cuda.so found in that directory

@michaelshin
Copy link
Contributor Author

  • Added a build script and updated the EC2 runner yaml to use said script
  • Added better tagging of the wheels so it is obvious which Python and CUDA versions were used to build it

@michaelshin
Copy link
Contributor Author

michaelshin commented Apr 13, 2023

Added an additional check on import to tell users if the runtime libraries are not linked

Screenshot from 2023-04-13 14-51-05

@codeclimate
Copy link

codeclimate bot commented Apr 17, 2023

Code Climate has analyzed commit 3fb73c5 and detected 0 issues on this pull request.

View more on Code Climate.

@michaelshin michaelshin merged commit 4f6b948 into main Apr 19, 2023
@michaelshin michaelshin deleted the include-cuda-libraries-to-wheel branch May 1, 2023 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants