Removed bootstrap in favor of module css#209
Merged
Conversation
There was a problem hiding this comment.
Copilot reviewed 19 out of 31 changed files in this pull request and generated no comments.
Files not reviewed (12)
- .vscode/settings.json: Language not supported
- package.json: Language not supported
- src/App.module.css: Language not supported
- src/DisplayNpc.module.css: Language not supported
- src/Footer.module.css: Language not supported
- src/NpcData.module.css: Language not supported
- src/NpcHistory.module.css: Language not supported
- src/UserInput.module.css: Language not supported
- src/styles/DisplayNpc.scss: Language not supported
- src/styles/Footer.scss: Language not supported
- src/styles/NpcData.scss: Language not supported
- src/styles/NpcHistory.scss: Language not supported
Comments suppressed due to low confidence (3)
src/main.tsx:3
- Removing the file extension in the App import may cause module resolution issues in some environments. Ensure the project's configuration supports this pattern.
import App from "./App";
src/UserInput.tsx:182
- The button rendering the 'Copied!' state lacks an explicit type attribute, which may default to 'submit' when used within a form. Consider adding type='button' to prevent unintended form submissions.
<button className={`${styles.button} ${styles.buttonOutline} ${styles.buttonOutlinePrimary}`}>
src/UserInput.tsx:194
- The 'Copy to Clipboard' button also lacks an explicit type attribute. Adding type='button' will prevent it from inadvertently submitting the form.
<button className={`${styles.button} ${styles.buttonOutline} ${styles.buttonOutlineSecondary}`}>
Cellule
commented
Apr 12, 2025
49948ee to
771a1d8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bootstrap has been a pain to maintain with all the breaking changes left and right.
I used AI assisted coding to get rid of it as much as possible.
The end result is not exactly the same, but I think it solves a few annoyances I've had over time in terms of consistency & readability
Changes
Screenshot/Examples
The following screenshot cut the background because of the way I took the screenshot, it scrolls properly on the website
Bryce Glorybluff - NPC Generator.pdf


This change is