Skip to content

Update minimum dev version to node 22 #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Cellule merged 1 commit into from
Apr 9, 2025
Merged

Update minimum dev version to node 22 #207

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 12 additions & 15 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,37 +11,34 @@ jobs:

strategy:
matrix:
node-version: [18.x, 20.x]
node-version: [22.x]

steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4

- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v3
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node-version }}

- name: install
run: |
npm install

- name: build
run: |
npm run build
- run: npm install
- run: npm run build

cypress:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v3
- name: install
run: |
npm install
- uses: actions/checkout@v4
- name: Use Node.js
uses: actions/setup-node@v4
with:
node-version: 22
Copy link

Copilot AI Apr 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency with the matrix configuration that specifies '22.x', please update this node version to '22.x' to avoid potential parsing or behavior discrepancies.

Suggested change
node-version: 22
node-version: 22.x

Copilot uses AI. Check for mistakes.
- run: npm install

# https://docs.cypress.io/guides/continuous-integration/github-actions
- name: Cypress run
# https://github.com/marketplace/actions/cypress-io
uses: cypress-io/github-action@v4.2.1 # use the explicit version number
uses: cypress-io/github-action@v6.7.16 # use the explicit version number
with:
start: npm run dev -- --host
wait-on: "http://localhost:3000"
8 changes: 4 additions & 4 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
{
"name": "dnd-generator",
"version": "0.5.0",
"version": "0.5.1",
"private": true,
"type": "module",
"engines": {
"npm": ">=9.0.0 <10.0.0",
"node": ">=18.0.0 <21.0.0"
"npm": ">=10.0.0",
"node": ">=22.0.0"
},
"scripts": {
"dev": "vite",
Expand Down