[TM-DEV] Autolate 516 fix #2308
Draft
+643
−368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Фикс карго консолей для 516 (версия2)
Убираю загогулину
Signed-off-by: Mirag1993 <145050764+Mirag1993@users.noreply.github.com>
Fix/cargo console cart limits
Fixed premature cart clearing on purchase failure - Cart now only clears after successful server confirmation Fixed search filter errors - Added proper array validation and error handling in search function Fixed cart item limit validation - Proper blocking of add-to-cart buttons when limit reached Added async purchase processing - Purchase button shows "Processing..." state during server communication Added server-controlled behavior constants - Cart limits and search limits now managed from DM code Added purchase state tracking - UI blocks interactions during purchase to prevent double-submissions Centralized constants management - Moved max_cart_items, search_results_limit from client to server Improved data validation - Enhanced validateData() function with proper fallbacks Enhanced error handling - Added try-catch blocks for async operations Better separation of concerns - Client waits for server response before state changes Applied DIY, KISS, YAGNI principles - Removed code duplication, simplified logic, eliminated premature actions Improved TypeScript types - Added server constants to Data interface Enhanced search functionality - Search now only matches item names (removed description matching) Better state management - Added purchasing state for proper async handling Fixed client-server communication - Proper async/await pattern for purchase operations Implemented single source of truth - All behavior constants now in DM code Improved UI responsiveness - Visual feedback during async operations (Короче наговнокодили , надо писать карго консоли с нуля)
findtext(D.name, params["to_search"]) is case-sensitive selfClear attribute causes UX confusion useLocalState is deprecated (says in your pr) DM ui_data logic doesn't properly handle search result display
Mirag1993
requested review from
MysticalFaceLesS,
Cuildipie and
KOCMODECAHTHUK
as code owners
Celadon-Bot
added
💬 TGUI
Autolate fix 2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Autolate 516 fix
Why It's Good For The Game
Changelog
🆑
/:cl: