Fix the example in the README #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryan-odea
requested changes
Dec 9, 2025
Member
ryan-odea
left a comment
ryan-odea
left a comment
There was a problem hiding this comment.
Thank you for noticing!
I was just about to PR some vignettes and the readme update and you beat me to it! - I think load_data() needs to be load_data("SEQdata")
remlapmot
force-pushed
the
fix-example-typo
branch
from
11e4ff6 to
8e84778
Compare
Contributor
Author
|
Thanks Ryan, I've added that. It was working without it as you have specified that as the default value of the argument in the function definition but I agree it makes it clearer with it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In trying to use this on our short course practical I just noticed that the README example no longer runs.
Hopefully this is the fix.