Skip to content

Conversation

@remlapmot
Copy link
Contributor

Hi Ryan

I had a look at this.

Great work.

As far as I can see the tests also pass under Python 3.13 and 3.14, so I see no reason not to add them into the project - unless you know of a reason.

Also I added the dev dependency-group to the pyproject.toml with pytest, black, isort, and the packages for the docs site (so those packages get installed when one runs uv sync).

You can test under different versions of Python quite quickly with uv virtual envs as follows:

uv venv --python 3.13
source .venv/bin/activate
uv sync
uv run pytest
deactivate

(I got one tiny warning about one of the dependency packages under Python 3.14 - but that's for that package to fix.)

(And I had to add pytest.approx() to the parallel test - but obvs not reasonable to expect different architectures to be equal down to like 10 d.p.)

cheers
Tom

@remlapmot remlapmot requested a review from ryan-odea December 5, 2025 15:20
@remlapmot
Copy link
Contributor Author

P.S. Not sure if I am meant to bump the version in pyproject.toml or not.

Copy link
Member

@ryan-odea ryan-odea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me - thanks for checking additional python versions.

@ryan-odea
Copy link
Member

ryan-odea commented Dec 5, 2025

P.S. Not sure if I am meant to bump the version in pyproject.toml or not.

Since this is just tests and config files, and we aren't planning to push to pypi, perhaps we hold off on bumping the version. If you want to initiate an update to pypi, I think it requires a different version

@remlapmot
Copy link
Contributor Author

thanks - that's very helpful info about the version number - I won't bump it

@remlapmot remlapmot merged commit 47e207d into main Dec 5, 2025
5 checks passed
@ryan-odea ryan-odea deleted the add-pythons branch December 9, 2025 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants