Check if app has macOS native version (PlayCover#1543)

* MACOS_APPS list and hasMacVersion * added error message - Added fetchAppID() function to fetch ID by boundIeID (maybe can be improved) - Added error message with 3 buttons: start anyway, quit ad open appstore (thats why i need ID and not bundleID) * removed unused import + added check on install * onInstall check --------- Co-authored-by: Depal1 <47154119+Depal1@users.noreply.github.com>
Catta1997 · Aug 26, 2024 · 58e948f · 58e948f
1 parent 0cfcffe
commit 58e948f
Show file tree

Hide file tree

Showing 5 changed files with 85 additions and 8 deletions.
diff --git a/PlayCover/AppInstaller/Downloader.swift b/PlayCover/AppInstaller/Downloader.swift
@@ -69,14 +69,20 @@ class DownloadApp {
                     return
                 }
             }
-
-            if let wrapedURL = url {
-                if wrapedURL.isFileURL {
-                    proceedInstall(url, deleteIPA: false)
-                } else {
-                    let (finalURL, urlIsValid) = NetworkVM.urlAccessible(url: wrapedURL, popup: true)
-                    if urlIsValid, let newWrappedURL = finalURL {
-                        proceedDownload(newWrappedURL)
+            if let url = url, let app = app {
+                let ipa = IPA(url: url)
+                Task {
+                    if await ipa.hasMacVersion(app: IPA.Application.store(app)) {
+                        cancel()
+                    } else {
+                        if url.isFileURL {
+                            proceedInstall(url, deleteIPA: false)
+                        } else {
+                            let (finalURL, urlIsValid) = NetworkVM.urlAccessible(url: url, popup: true)
+                            if urlIsValid, let newWrappedURL = finalURL {
+                                proceedDownload(newWrappedURL)
+                            }
+                        }
                     }
                 }
             }

diff --git a/PlayCover/AppInstaller/Installer.swift b/PlayCover/AppInstaller/Installer.swift
@@ -59,6 +59,12 @@ class Installer {
                 try ipa.allocateTempDir()
 
                 let app = try ipa.unzip()
+                if await ipa.hasMacVersion(app: IPA.Application.base(app)) {
+                    ipa.releaseTempDir()
+                    InstallVM.shared.next(.failed, 0.95, 1.0)
+                    returnCompletion(nil)
+                    return
+                }
                 InstallVM.shared.next(.library, 0.5, 0.55)
                 try saveEntitlements(app)
                 let machos = resolveValidMachOs(app)

diff --git a/PlayCover/Utils/Extensions/PlayAppExtensions.swift b/PlayCover/Utils/Extensions/PlayAppExtensions.swift
@@ -65,4 +65,15 @@ extension PlayApp {
     func removeAlias() {
         FileManager.default.delete(at: aliasURL)
     }
+
+    var hasMacVersion: Bool {
+        PlayApp.MACOS_APPS.contains(info.bundleIdentifier)
+    }
+
+    static let MACOS_APPS = [
+        "com.innersloth.amongus",
+        "com.devsisters.ck",
+        "com.miHoYo.bh3global"
+    ]
+
 }
diff --git a/PlayCover/Utils/IPA.swift b/PlayCover/Utils/IPA.swift
@@ -65,4 +65,55 @@ public class IPA {
         let documentsDirectory = paths[0]
         return documentsDirectory
     }
+
+    enum Application {
+        case base(BaseApp)
+        case store(StoreAppData)
+    }
+
+    @MainActor
+    func hasMacVersion(app: Application) async -> Bool {
+        let bundleID: String
+        let appID: Int
+        switch app {
+        case .base(let base):
+            bundleID = base.info.bundleIdentifier
+            let urlString = "https://itunes.apple.com/lookup?bundleId=\(bundleID)"
+            let itunes: ITunesResponse? = await getITunesData(urlString)
+            appID = itunes?.results.first?.trackId ?? 0
+        case .store(let store):
+            bundleID = store.bundleID
+            let appLookup = store.itunesLookup
+            let stringArray = appLookup.components(separatedBy: CharacterSet.decimalDigits.inverted)
+            appID = Int(stringArray.last ?? "0") ?? 0
+        }
+        let noMacAlert = UserDefaults.standard.bool(forKey: "\(bundleID).noMacAlert")
+        if PlayApp.MACOS_APPS.contains(bundleID), !noMacAlert {
+            let alert = NSAlert()
+            alert.messageText = NSLocalizedString("alert.error", comment: "")
+            alert.informativeText = String(
+                format: NSLocalizedString("macos.version", comment: "")
+            )
+            alert.alertStyle = .warning
+            alert.addButton(withTitle: NSLocalizedString("alert.install.anyway", comment: ""))
+            alert.addButton(withTitle: NSLocalizedString("alert.open.appstore", comment: ""))
+            alert.addButton(withTitle: NSLocalizedString("button.Cancel", comment: ""))
+            let result = alert.runModal()
+            switch result {
+            case .alertFirstButtonReturn:
+                UserDefaults.standard.set(true, forKey: "\(bundleID).noMacAlert")
+            case .alertSecondButtonReturn:
+                if appID != 0 {
+                    guard let urlApp = URL(string:
+                                            "itms-apps://apps.apple.com/app/id\(appID)")
+                    else {return true}
+                    NSWorkspace.shared.open(urlApp)
+                }
+                return true
+            default:
+                return true
+            }
+        }
+        return false
+    }
 }
diff --git a/PlayCover/en.lproj/Localizable.strings b/PlayCover/en.lproj/Localizable.strings
@@ -285,4 +285,7 @@
 "keycover.alert.title" = "Keychain was not unlocked";
 "keycover.alert.content" = "Keychain access has been disabled for the current session";
 
+"macos.version" = "This app can be installed from Mac App Store";
 "alert.install.anyway" = "Install Anyway";
+"alert.open.appstore" = "Open Mac App Store";
+