Skip to content

Conversation

@TauBossss
Copy link

@TauBossss TauBossss commented Jul 17, 2021

Removed all hardcoding of scratch3 opcodes, used opcode classes instead.

Your checklist for this pull request

Please review the contributing guidelines and wiki pages of this repository.

  • Include the name of the Jira ticket in the PR’s title
  • Include a summary of the changes plus the relevant context
  • Choose the proper base branch (develop)
  • Confirm that the changes follow the project’s coding guidelines
  • Verify that the changes generate no compiler warnings
  • Perform a self-review of the changes
  • Verify to commit no other files than the intentionally changed ones
  • Include reasonable and readable tests verifying the added or changed behavior
  • Confirm that new and existing unit tests pass locally
  • Check that the commits’ message style matches the project’s guideline (Replace occurences of CATROBAT or CAT with STCC)
  • Stick to the project’s gitflow workflow
  • Verify that your changes do not have any conflicts with the base branch
  • Post a message in the #stcc Slack channel and ask for a code reviewer

TauBossss added 12 commits May 28, 2021 12:54
test
test
test
test
maybe works noew
STCC-295 refactor run_tests [TN]
This reverts commit b70dd0b.
Almost done needs checking
@TauBossss TauBossss requested a review from lildeaf July 17, 2021 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant