Skip to content

Conversation

@Kale2605
Copy link
Contributor

@Kale2605 Kale2605 commented Jan 26, 2026

getActivity() sometimes null... not yet attached. Fix by wait and try again.

https://catrobat.atlassian.net/browse/IDE-307?atlOrigin=eyJpIjoiNjk3NDllZDk2YmUyNDk2NmFjM2NkYjkwNjRhYzFhNGYiLCJwIjoiaiJ9

Your checklist for this pull request

Please review the contributing guidelines and wiki pages of this repository.

  • Include the name of the Jira ticket in the PR’s title
  • Include a summary of the changes plus the relevant context
  • Choose the proper base branch (develop)
  • Confirm that the changes follow the project’s coding guidelines
  • Verify that the changes generate no compiler or linter warnings
  • Perform a self-review of the changes
  • Verify to commit no other files than the intentionally changed ones
  • Include reasonable and readable tests verifying the added or changed behavior
  • Confirm that new and existing unit tests pass locally
  • Check that the commits’ message style matches the project’s guideline
  • Stick to the project’s gitflow workflow
  • Verify that your changes do not have any conflicts with the base branch
  • After the PR, verify that all CI checks have passed
  • Post a message in the catroid-stage or catroid-ide Slack channel and ask for a code reviewer

@Kale2605 Kale2605 marked this pull request as ready for review January 26, 2026 08:27
Copy link
Contributor

@Frajhamster Frajhamster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, except that on SonarQube your code introduced a new issue, which still passes the QualityGate check, so you can decide to take a look at it and try to fix it, or leave it like it is now, up to you.

@Kale2605
Copy link
Contributor Author

Looks good, except that on SonarQube your code introduced a new issue, which still passes the QualityGate check, so you can decide to take a look at it and try to fix it, or leave it like it is now, up to you.

Done

getActivity() sometimes null... not yet attached. Fix by wait and try again. And fix code smell.
@sonarqubecloud
Copy link

@Kale2605 Kale2605 changed the title IDE 307 Fix failure in quarantined test suite IDE-307 Fix failure in quarantined test suite Jan 27, 2026
@ratschillerp ratschillerp added the Active Member Tickets that are assigned to members that are still currently active label Jan 29, 2026
@dorianpercic dorianpercic self-requested a review January 29, 2026 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Active Member Tickets that are assigned to members that are still currently active

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants