Skip to content

charts for stats and token screen #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Arvrairobo wants to merge 1 commit into
base: main
Choose a base branch
from
Open

charts for stats and token screen #182

Arvrairobo wants to merge 1 commit into from

Conversation

@Arvrairobo
Copy link

@Arvrairobo Arvrairobo commented Jun 26, 2025

issue #163

@pkarw let me know if all okay

@CLAassistant
Copy link

CLAassistant commented Jun 26, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

pkarw
pkarw requested changes Jun 28, 2025
View reviewed changes
Copy link
Contributor

@pkarw pkarw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Thanks for this PR it's overall a great feature, just minor changes required due to missing translation calls

Could you also please paste the screenshots how this looks like? Thanks!

src/app/[locale]/admin/settings/stats/page.tsx
<div className="grid gap-6 grid-cols-1 sm:grid-cols-2 lg:grid-cols-4">
<Card>
<CardHeader>
<CardTitle>Available Budget</CardTitle>
Copy link
Contributor

@pkarw pkarw Jun 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do use the t() translation helper when displaying the labels

src/app/[locale]/admin/settings/stats/page.tsx

<Card>
<CardHeader>
<CardTitle>Available Agents</CardTitle>
Copy link
Contributor

@pkarw pkarw Jun 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do use the t() translation helper when displaying the labels

src/app/[locale]/admin/settings/stats/page.tsx

<Card>
<CardHeader>
<CardTitle>Available Results</CardTitle>
Copy link
Contributor

@pkarw pkarw Jun 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do use the t() translation helper when displaying the labels

src/app/[locale]/admin/settings/stats/page.tsx

<Card>
<CardHeader>
<CardTitle>Available Sessions</CardTitle>
Copy link
Contributor

@pkarw pkarw Jun 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do use the t() translation helper when displaying the labels

@Arvrairobo
Copy link
Author

Arvrairobo commented Jun 28, 2025

@pkarw ok i will ammend as per above and send another PR.

Regarding screenshot, it is already mentioned in the issue issue #163

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pkarw pkarw pkarw requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Arvrairobo @CLAassistant @pkarw @jack-solutions